Carol (Nichols || Goulding)
d532801172
Reword some things on another reading
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
0705ea8eff
Work through adding pub
because of warnings in a different way
...
I felt like the previous version was a bit vague and left the impression
that dead code warnings should be fixed by adding `pub` everywhere. What
I think it was *trying* to say was that because we WANT these functions
to be public for external folks to use, THAT'S why we're getting the
warnings and why pub is the fix for it.
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
4835474c82
Oops, this comment needs to be a rust comment
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
b73f3d1794
Some small wording edits
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
31863c3549
Set up the example context a bit better
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
9627117464
Use parens with functions in prose
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
dce64eb42b
Remove unfulfilled foreshadowing
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
56f69991cf
Move pub use
discussion to the library chapter
...
Maybe we should think about a separate book about creating a library ;)
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
4bab40d45e
Add an example of a naming conflict caused by glob import
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
f0400e75d6
Clarify that it's not "many", it's "all" that glob imports
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
40f08bba94
Encourage curly braces and lists for importing multiple things
...
This is more common than multiple lines or globs, so we should encourage
it.
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
e427b5f3a9
Make the tree output text so it doesn't get tested as rust
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
14adf56e8a
Oops, hard wrap
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
7dc4e78ba7
Clear up the module rules
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
84ba655cd9
Make compilation messages use the projects dir
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
68f465bbc3
Use network/client/server as mods and connect as functions
...
Instead of foo/bar/tests and it_works. This doesn't make the most sense
ever, but it's a little better than metasyntactic variables :)
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
f94d402f2d
Add an explicit definition of what a module is
...
Felt like this was missing just now, but not really the first time I
read this. Strange.
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
a8bf2acd46
Take aturon's suggestion about the contents of the foo module
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
6aba5d834b
Remove the mention of "anonymous module" that confused me
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
89541a1649
Clarify where we'd have to use the full namespaced fn
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
dd0fdcd2dc
Explain libraries vs binaries a bit since this is our first lib
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
926d5bf37f
Take aturon's suggestions about what we're bringing into scope
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
a5b42c6dc9
Remove a vague part about "things"; next sentence is better
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
816bf59c04
Small wording, punctuation, etc edits
2016-08-26 17:41:35 -07:00
Steve Klabnik
e3d1e37c5b
Add use
2016-08-26 17:41:35 -07:00
Steve Klabnik
1601df9a5b
Start modules _again_
2016-08-26 17:41:35 -07:00
Carol (Nichols || Goulding)
cae55482e7
Ignore some links for print now that we have a script to remove!!!
2016-08-26 17:23:53 -07:00
Carol (Nichols || Goulding)
6c8e34413e
Add remove links script to the nostarch delivery script
2016-08-26 16:43:48 -07:00
Carol (Nichols || Goulding)
109f6beebb
Merge remote-tracking branch 'origin/pr/228'
2016-08-26 16:14:48 -07:00
Carol (Nichols || Goulding)
2a57d811e8
Add an issue template explaining the new/old book business
2016-08-26 16:10:21 -07:00
Carol (Nichols || Goulding)
1f4b3c0e35
Leave a note to ourselves about documentation examples
...
Fixes #229 by reminding us for when that chapter gets more work.
2016-08-26 15:56:27 -07:00
Steve Klabnik
51a077d3fe
Merge pull request #232 from rust-lang/fix-build
...
Fix the build
2016-08-26 16:24:50 -04:00
Steve Klabnik
3a7317a6a8
Fix the build
...
We can't use the cache dir because cargo install doesn't really have a
way to say "make sure this is installed". If it is, then it errors out,
and you can force it to install, but then we're not using the cache.
2016-08-26 16:11:55 -04:00
Steve Klabnik
bcd04062b9
Merge pull request #230 from rust-lang/cache
...
Cache cargo output
2016-08-26 15:23:02 -04:00
Steve Klabnik
d09be121c2
Merge pull request #231 from rust-lang/remove-beta
...
remove beta from the build
2016-08-26 15:22:44 -04:00
Steve Klabnik
077d8d3571
remove beta from the build
...
A rust bug is currently preventing this from building, and https://github.com/rust-lang/book/pull/134 will move this to nightly-only for the time being.
2016-08-26 14:05:21 -04:00
Steve Klabnik
b1298264df
Cache cargo output
...
https://docs.travis-ci.com/user/caching/#Rust-Cargo-cache
2016-08-26 13:45:25 -04:00
Raymond Edwards
34cbd9e72a
Merge upstream/master
2016-08-25 13:37:38 -03:00
Raymond Edwards
7739f44133
remove_links.rs now removes links and link references marked as <\!-- ignore -->
2016-08-25 13:34:49 -03:00
Carol (Nichols || Goulding)
a2bc576183
Make the println text match the variable name
...
Whoops! Missed these when we renamed the variable.
Fixes #219 .
2016-08-25 11:56:58 -04:00
Carol (Nichols || Goulding)
8cb6aae049
Don't say we haven't seen double colon yet when we have
...
Fixes #217 .
2016-08-25 11:55:20 -04:00
Carol (Nichols || Goulding)
6cb337e3e8
Don't say we haven't used snake case for vars yet; we have
...
Fixes #215 .
2016-08-25 11:53:30 -04:00
Carol (Nichols || Goulding)
ec02c7e477
Remove false statement that this is the first error we've seen
...
Fixes #214 .
2016-08-25 11:52:25 -04:00
Carol (Nichols || Goulding)
df0fd1bcca
Remove oft-duplicated cargo new
instructions
...
Fixes #205 .
2016-08-25 11:48:54 -04:00
Carol (Nichols || Goulding)
65f8beb9ab
Swap order so Collections comes before Error Handling
2016-08-25 11:21:39 -04:00
Raymond Edwards
0ae8fba826
Added remove_links.rs, only reads from stdin at the moment and failsto build
2016-08-24 22:18:43 -03:00
Carol (Nichols || Goulding)
8af7154847
Update SUMMARY.md
2016-08-24 14:07:22 -04:00
Carol (Nichols || Goulding)
4dbb8da8e7
Merge pull request #227 from brennx0r/master
...
Minor edits
2016-08-24 09:39:28 -04:00
Carol (Nichols || Goulding)
849fa69dcc
Merge pull request #225 from spastorino/readline
...
It's read_line not readline
2016-08-24 09:36:59 -04:00
Carol (Nichols || Goulding)
f8452503c1
Merge pull request #224 from spastorino/prelude
...
Fix prelude link
2016-08-24 09:35:45 -04:00