mirror of
https://github.com/zeromicro/go-zero.git
synced 2025-02-03 00:38:40 +08:00
Potential fix for code scanning alert no. 57: Arbitrary file access during archive extraction ("Zip Slip") (#4604)
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This commit is contained in:
parent
a32f6d7642
commit
c71829c8de
@ -2,9 +2,11 @@ package zipx
|
||||
|
||||
import (
|
||||
"archive/zip"
|
||||
"fmt"
|
||||
"io"
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
|
||||
"github.com/zeromicro/go-zero/tools/goctl/util/pathx"
|
||||
)
|
||||
@ -39,6 +41,12 @@ func fileCopy(file *zip.File, destPath string) error {
|
||||
return err
|
||||
}
|
||||
defer rc.Close()
|
||||
|
||||
// Ensure the file path does not contain directory traversal elements
|
||||
if strings.Contains(file.Name, "..") {
|
||||
return fmt.Errorf("invalid file path: %s", file.Name)
|
||||
}
|
||||
|
||||
abs, err := filepath.Abs(file.Name)
|
||||
if err != nil {
|
||||
return err
|
||||
|
Loading…
Reference in New Issue
Block a user