github_mirrors/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2025-02-03 00:38:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: prevent a crash if there is a unique key constraint with a nil field. (#3770)

Browse Source
This commit is contained in:
POABOB 2023-12-11 21:29:05 +08:00 committed by GitHub
parent 22c98beb24
commit a1bbac3c6c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tools/goctl/model/sql/parser/parser.go
View File

@ -83,8 +83,9 @@ func Parse(filename, database string, strict bool) ([]*Table, error) {
primaryColumn string
primaryColumnSet = collection.NewSet()
uniqueKeyMap = make(map[string][]string)
normalKeyMap = make(map[string][]string)
columns = e.Columns
// Unused local variable
// normalKeyMap = make(map[string][]string)
columns = e.Columns
)
for _, column := range columns {
@ -144,20 +145,26 @@ func Parse(filename, database string, strict bool) ([]*Table, error) {
var (
uniqueIndex = make(map[string][]*Field)
normalIndex = make(map[string][]*Field)
// Unused local variable
// normalIndex = make(map[string][]*Field)
)
for indexName, each := range uniqueKeyMap {
for _, columnName := range each {
// Prevent a crash if there is a unique key constraint with a nil field.
if fieldM[columnName] == nil {
return nil, fmt.Errorf("table %s: unique key with error column name[%s]", e.Name, columnName)
}
uniqueIndex[indexName] = append(uniqueIndex[indexName], fieldM[columnName])
}
}
for indexName, each := range normalKeyMap {
for _, columnName := range each {
normalIndex[indexName] = append(normalIndex[indexName], fieldM[columnName])
}
}
// Unused local variable
// for indexName, each := range normalKeyMap {
// for _, columnName := range each {
// normalIndex[indexName] = append(normalIndex[indexName], fieldM[columnName])
// }
// }
checkDuplicateUniqueIndex(uniqueIndex, e.Name)