github_mirrors/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2025-02-02 16:28:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

chore: let logx.SetWriter can be called anytime (#2186)

Browse Source
This commit is contained in:
Kevin Wan 2022-07-24 14:15:57 +08:00 committed by GitHub
parent 685d14e662
commit 9b334b5428
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/logx/logs.go
View File

@ -199,11 +199,8 @@ func SetLevel(level uint32) {
}
// SetWriter sets the logging writer. It can be used to customize the logging.
// Call Reset before calling SetWriter again.
func SetWriter(w Writer) {
if writer.Load() == nil {
writer.Store(w)
}
writer.Store(w)
}
// SetUp sets up the logx. If already set up, just return nil.

5
core/logx/logs_test.go
View File

@ -603,8 +603,9 @@ func TestSetWriter(t *testing.T) {
SetWriter(nopWriter{})
assert.NotNil(t, writer.Load())
assert.True(t, writer.Load() == nopWriter{})
SetWriter(new(mockWriter))
assert.True(t, writer.Load() == nopWriter{})
mocked := new(mockWriter)
SetWriter(mocked)
assert.Equal(t, mocked, writer.Load())
}
func TestWithGzip(t *testing.T) {

3
zrpc/internal/serverinterceptors/statinterceptor.go
View File

@ -69,8 +69,7 @@ func logDuration(ctx context.Context, method string, req interface{}, duration t
if err != nil {
logx.WithContext(ctx).Errorf("%s - %s", addr, err.Error())
} else if duration > slowThreshold.Load() {
logger.Slowf("[RPC] slowcall - %s - %s - %s",
addr, method, string(content))
logger.Slowf("[RPC] slowcall - %s - %s - %s", addr, method, string(content))
} else {
logger.Infof("%s - %s - %s", addr, method, string(content))
}