github_mirrors/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2025-02-02 16:28:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix rolling window bug (#340)

Browse Source
This commit is contained in:
zjbztianya 2021-01-03 20:27:47 +08:00 committed by GitHub
parent 5bc01e4bfd
commit 2ee95f8981
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 26 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/collection/rollingwindow.go
View File

@ -96,7 +96,7 @@ func (rw *RollingWindow) updateOffset() {
}
rw.offset = (offset + span) % rw.size
rw.lastTime = timex.Now()
rw.lastTime = time.Duration(int(rw.lastTime) + int(rw.interval)*span)
}
type Bucket struct {

25
core/collection/rollingwindow_test.go
View File

@ -45,6 +45,31 @@ func TestRollingWindowAdd(t *testing.T) {
assert.Equal(t, []float64{5, 15, 7}, listBuckets())
}
func TestRollingWindowAdd2(t *testing.T) {
const size = 3
interval := time.Millisecond * 50
r := NewRollingWindow(size, interval)
listBuckets := func() []float64 {
var buckets []float64
r.Reduce(func(b *Bucket) {
buckets = append(buckets, b.Sum)
})
return buckets
}
assert.Equal(t, []float64{0, 0, 0}, listBuckets())
r.Add(1)
assert.Equal(t, []float64{0, 0, 1}, listBuckets())
time.Sleep(time.Millisecond * 90)
r.Add(2)
r.Add(3)
assert.Equal(t, []float64{0, 1, 5}, listBuckets())
time.Sleep(time.Millisecond * 20)
r.Add(4)
r.Add(5)
r.Add(6)
assert.Equal(t, []float64{1, 5, 15}, listBuckets())
}
func TestRollingWindowReset(t *testing.T) {
const size = 3
r := NewRollingWindow(size, duration, IgnoreCurrentBucket())