github_mirrors/go-zero
1
0
Fork 0
mirror of https://github.com/zeromicro/go-zero.git synced 2025-02-03 00:38:40 +08:00
Code Issues Packages Projects Releases Wiki Activity

align bucket boundary to interval in rolling window (#345)

Browse Source
This commit is contained in:
Kevin Wan 2021-01-04 11:17:59 +08:00 committed by GitHub
parent efa43483b2
commit 0786862a35
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
core/collection/rollingwindow.go
View File

@ -96,7 +96,9 @@ func (rw *RollingWindow) updateOffset() {
}
rw.offset = (offset + span) % rw.size
rw.lastTime = rw.lastTime + rw.interval*time.Duration(span)
now := timex.Now()
// align to interval time boundary
rw.lastTime = now - (now-rw.lastTime)%rw.interval
}
type Bucket struct {

5
core/collection/rollingwindow_test.go
View File

@ -129,6 +129,11 @@ func TestRollingWindowBucketTimeBoundary(t *testing.T) {
r.Add(5)
r.Add(6)
assert.Equal(t, []float64{1, 5, 15}, listBuckets())
time.Sleep(time.Millisecond * 100)
r.Add(7)
r.Add(8)
r.Add(9)
assert.Equal(t, []float64{0, 0, 24}, listBuckets())
}
func TestRollingWindowDataRace(t *testing.T) {